Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toZigbee - light_brightness_move line 248 #948

Closed
fnfid opened this issue Jan 28, 2020 · 1 comment
Closed

toZigbee - light_brightness_move line 248 #948

fnfid opened this issue Jan 28, 2020 · 1 comment

Comments

@fnfid
Copy link

fnfid commented Jan 28, 2020

Hi, as brightness_move seem to use always 'moveWithOnOff' it would be great to optify this to 'move' by any option set, as this easyfies to mimick the original IKEA remote sending 'move' natively.
As I only need 'move' for now i included 'sed -i s/moveWithOnOff/move/ toZigbee.js ' in my updade script as a workaround, works fine so far.
Maybe something like {"moveWithOnOff": true} with default true for compatibility reasons can add this functionality.
Koenkk added a commit that referenced this issue Jan 28, 2020
@Koenkk
Don't turn off with brightness_move. #948
7184aec
@Koenkk
Copy link
Owner

Koenkk commented Jan 28, 2020

It should be move from the start, fixed it thanks!

@Koenkk Koenkk closed this as completed Jan 28, 2020
xmow49 pushed a commit to xmow49/zigbee-herdsman-converters that referenced this issue Jun 14, 2024
@Koenkk
chore(master): release 0.35.3 (Koenkk#948)
bebac56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Koenkk @fnfid