Yale YRD210 wrong battery reading

[presslab-us]

My Yale YRD210 locks (I have four) are correctly detected and the functionality is fine. But the battery reading is incorrect, it reads half what it should. I tested with new batteries and it reports exactly 50%.

zigbee-herdsman-converters/devices.js

Line 6285 in fa037d5

fromZigbee: [fz.lock, fz.lock_operation_event, fz.battery],

Changing that line to the same as YRD220 like so:

zigbee-herdsman-converters/devices.js

Line 6317 in fa037d5

fromZigbee: [fz.lock, fz.lock_operation_event, fz.legacy_battery],

works and fixes the battery problem.

I'm not sure who wrote that original code, and GitHub blame isn't working (I get a Unicorn). Is it safe to assume that my four locks are correct and the original implementation is not? I'm not sure...

[Koenkk]

The implementation is correct, but the locks are not complying to the Zigbee specification (e.g. report of 200 = 100%, report of 100 = 50%).

Anyway, pushed the fix to the repo, thanks!

[presslab-us]

Yep! I agree the devices are not meeting Zigbee spec. When I said implementation I meant the specific definition in devices.js to match the YRD210. Thanks!