-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
light.toggle(on) with a transition attribute set (after light.turn_off) don't set brightness to correct previous level #1097
Comments
I cannot reproduce this but probably I'm using slightly different commands. Could you provide the log when reproducing this bug and running with Some background on why you get these bugs when using transition: Zigbee does not have commands to turn on/off lights with a transition (besides one with a fixed 0.8 transition). Therefore we turning a bulb off with a transition, we set the brightness to 0. When the bulb is turned on again we need to restore this transition. |
Hi' Koenkk. OK. Wasn't aware of that. Thought that transition was so low level, that it was handled completely by bulbs firmware. Anyway I'm on hassio and tried googling how to enable herdsman logging ? Hopefully this log contains all the info you need ? Here goes:
|
…n and is turned on with transition. #1097
Thanks, fixed it, will be available in the latest dev branch in a few hours. |
I confirm this fixed the bug👍 Thanks for fixing this @Koenkk and thank you for all the effort you put into this project :) |
Hi' Koenkk. Xavi has already tested and confirmed fix. |
Hi' Koenkk.
I'm quite sure this issue is related to the other, newly fixed, brightness issue #1073
It's somewhat the 'opposite' error of what was previously fixed.
Actually Xavi, the developer of ControllerX app, found this bug after new tests with the updated z2m-edge:
Environment:
Hass.io - Home Assistant 0.107.7
zigbee2mqtt-edge (but also on latest z2m-stable version)
Ikea White Spectrum bulb on z2m integration
Case:
Then the brightness is NOT set back to 50%, but to a 'different' brightness.
This can be repeated over and over again with same result.
There's actually a pattern to the 'brightness set error'. The brightness set is ALWAYS the PREVIOUS brightness, until an lights off or toggle off is called with a transition attribute set. Then this brightness becomes new 'previous brightness' (Hope this somewhat difficult sentence makes any sense ?)
However, if I remove the "transition" attribute, I do not experience this. Then light always turns on at correct previous brightness.
ControllerX Github issue reference: xaviml/controllerx#58
Hope you can fix this as well, Koenkk 🙏😃🙋♂️
Ciao !
The text was updated successfully, but these errors were encountered: