Change BASE_REPO_URL to raw.githubusercontent.com #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Koenkk#673 By using raw.githubusercontent.com over github.com it is possible to access files over IPv6. This helps in environments where IPv4 is not available.
Nerivec
reviewed
Feb 8, 2025
tests/data.test.ts
Outdated
| @@ -41,7 +41,7 @@ export const IMAGE_V14_1_METAS = { | |||
| fileVersion: 14, | |||
| fileSize: 249694, | |||
| originalUrl: undefined, | |||
| url: `https://github.com/Koenkk/zigbee-OTA/raw/master/images/${IMAGES_TEST_DIR}/${IMAGE_V14_1}`, | |||
| url: `https://raw.githubusercontent.com/Koenkk/zigbee-OTA/master/images/${IMAGES_TEST_DIR}/${IMAGE_V14_1}`, | |||
There was a problem hiding this comment.
Probably should take the opportunity to replace all https://raw.githubusercontent.com/Koenkk/zigbee-OTA/master with ${BASE_REPO_URL}${REPO_BRANCH} / ${common.BASE_REPO_URL}${common.REPO_BRANCH} (depending on imports) to avoid future needs for manual adjustments.
Actually, with this URL style, it might even be possible to just combine the two into BASE_REPO_URL (base+branch I mean). Have to check occurrences of it, see if it works everywhere.
There was a problem hiding this comment.
I have adjusted the PR according to your request.
|
Note: run reprocess after this is merged to update all manifests automatically. |
2016ab9 to
807f8b7
Compare
|
Thanks! |
Koenkk
added a commit
that referenced
this pull request
Feb 10, 2025
Koenkk
added a commit
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673
By using raw.githubusercontent.com over github.com it is possible to access files over IPv6. This helps in environments where IPv4 is not available.