Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom firmware from pvvx for Xiaomi LYWSD03MMC #441

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

kwiateusz
Copy link
Contributor

Resository the file came from: https://github.com/pvvx/ZigbeeTLc

@kwiateusz kwiateusz changed the title Add custom firmware from pvss for Xiaomi LYWSD03MMC Add custom firmware from pvvx for Xiaomi LYWSD03MMC Feb 5, 2024
@Koenkk
Copy link
Owner

Koenkk commented Feb 5, 2024

@devbis @krzysztof-kwitt asking because of Koenkk/zigbee-herdsman-converters#7015, can I merge this?

@devbis
Copy link
Contributor

devbis commented Feb 6, 2024

I don't have any objections. Though, this fork in it's current state it will not be supported by converters due to a different structure of clusters and the exactly same model/manufacturer.

@kwiateusz kwiateusz force-pushed the xiaomi branch 2 times, most recently from dde0504 to 878803c Compare February 6, 2024 08:10
@kwiateusz kwiateusz closed this Feb 6, 2024
@kwiateusz kwiateusz deleted the xiaomi branch February 6, 2024 09:20
@kwiateusz
Copy link
Contributor Author

kwiateusz commented Feb 6, 2024

If it will not be supported then there is no point in adding, thanks for the information and I need to migrate my devices :)

@krzysztof-kwitt
Copy link

@kwiateusz We already are working to support this. It still makes sense for me.

@krzysztof-kwitt
Copy link

krzysztof-kwitt commented Feb 6, 2024

Latest version of Z2M supports pvvx firmware.

@kwiateusz kwiateusz restored the xiaomi branch February 6, 2024 09:24
@kwiateusz kwiateusz reopened this Feb 6, 2024
@devbis
Copy link
Contributor

devbis commented Feb 6, 2024

@kwiateusz It will be supported but without changes in pvvx's firmware pvvx/ZigbeeTLc#52 only basic functionality (temperature + humidity) will be available with z2m. Either custom convertor will be required.

@pbranly
Copy link

pbranly commented Feb 6, 2024

Hi
Could you explain the role of those additional settings ?
In z2m there are 2 ways to change temperature and humidity calibration. Which one is used ?
In addition there are also settings for confort min/max temp and humidity. Same question : what is the role of those new settings
Thanks
Phil

@devbis
Copy link
Contributor

devbis commented Feb 6, 2024

@pbranly Additional settings affect display values as well, while z2m internal calibration only modifies data in z2m and mqtt.
Comfort parameters is a configuration for happy/sad face on the display.

@kwiateusz
Copy link
Contributor Author

I've pushed a new version which shouldn't interfere with devbis converter

@Koenkk
Copy link
Owner

Koenkk commented Feb 14, 2024

@devbis @krzysztof-kwitt can you do a final check?

@devbis
Copy link
Contributor

devbis commented Feb 15, 2024

LGTM

@Koenkk Koenkk merged commit 91d75b8 into Koenkk:master Feb 15, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Feb 15, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants