Skip to content

Commit

Permalink
Remove a mention to Steve on r? example
Browse files Browse the repository at this point in the history
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
  • Loading branch information
JohnTitor authored and tshepang committed Jul 18, 2022
1 parent d306b66 commit d2577b5
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/doc/rustc-dev-guide/src/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,12 @@ to review your request based on which files you changed.

If you want to request that a specific person reviews your pull request, you
can add an `r?` to the pull request description or in a comment. For example,
[Steve][steveklabnik] usually reviews documentation changes. So if you were to
make a documentation change, add
if you want to ask a review to @awesome-reviewer, add

r? @steveklabnik
r? @awesome-reviewer

to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign
[@steveklabnik][steveklabnik] instead of a random person. This is entirely optional.
them instead of a random person. This is entirely optional.

You can also assign a random reviewer from a specific team by writing `r? rust-lang/groupname`.
So if you were making a diagnostics change, then you could get a reviewer from the diagnostics
Expand Down Expand Up @@ -135,7 +134,6 @@ speed the process up. Typically only small changes that are expected not to conf
with one another are marked as "always roll up".

[rust-highfive]: https://github.com/rust-highfive
[steveklabnik]: https://github.com/steveklabnik
[@bors]: https://github.com/bors
[merge-queue]: https://bors.rust-lang.org/queue/rust

Expand Down

0 comments on commit d2577b5

Please sign in to comment.