Merge pull request #286 from lucasmichot/feature/fixes

Some fixes
KnpLabs · Jul 3, 2015 · 9010dbe · 9010dbe
2 parents c49b2ec + d6602e7
commit 9010dbe
Show file tree

Hide file tree

Showing 32 changed files with 65 additions and 94 deletions.
diff --git a/lib/Github/Api/Repository/Assets.php b/lib/Github/Api/Repository/Assets.php
@@ -5,7 +5,6 @@
 use Github\Api\AbstractApi;
 use Github\Exception\ErrorException;
 use Github\Exception\MissingArgumentException;
-use Github\HttpClient\HttpClient;
 
 /**
  * @link   http://developer.github.com/v3/repos/releases/

diff --git a/lib/Github/Api/Repository/Contents.php b/lib/Github/Api/Repository/Contents.php
@@ -173,7 +173,6 @@ public function update($username, $repository, $path, $content, $message, $sha,
         return $this->put($url, $parameters);
     }
 
-
     /**
      * Deletes a file from a repository.
      *

diff --git a/lib/Github/Api/Search.php b/lib/Github/Api/Search.php
@@ -2,12 +2,6 @@
 
 namespace Github\Api;
 
-use Github\Api\Issue\Comments;
-use Github\Api\Issue\Events;
-use Github\Api\Issue\Labels;
-use Github\Api\Issue\Milestones;
-use Github\Exception\MissingArgumentException;
-
 /**
  * Implement the Search API.
  *

diff --git a/lib/Github/HttpClient/Listener/ErrorListener.php b/lib/Github/HttpClient/Listener/ErrorListener.php
@@ -5,7 +5,6 @@
 use Github\Exception\TwoFactorAuthenticationRequiredException;
 use Github\HttpClient\Message\ResponseMediator;
 use Guzzle\Common\Event;
-use Guzzle\Http\Message\Response;
 use Github\Exception\ApiLimitExceedException;
 use Github\Exception\ErrorException;
 use Github\Exception\RuntimeException;

diff --git a/test/Github/Tests/Api/CurrentUser/DeployKeysTest.php b/test/Github/Tests/Api/CurrentUser/DeployKeysTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class DeployKeysTest extends TestCase
 {
     /**
@@ -57,7 +55,7 @@ public function shouldCreateKey()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateKeyWithoutTitleParam()
     {
@@ -72,7 +70,7 @@ public function shouldNotCreateKeyWithoutTitleParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateKeyWithoutKeyParam()
     {
@@ -104,7 +102,7 @@ public function shouldUpdateKey()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotUpdateKeyWithoutTitleParam()
     {
@@ -119,7 +117,7 @@ public function shouldNotUpdateKeyWithoutTitleParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotUpdateKeyWithoutKeyParam()
     {

diff --git a/test/Github/Tests/Api/CurrentUser/EmailsTest.php b/test/Github/Tests/Api/CurrentUser/EmailsTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class EmailsTest extends TestCase
 {
     /**
@@ -56,7 +54,7 @@ public function shouldRemoveEmails()
 
     /**
      * @test
-     * @expectedException Github\Exception\InvalidArgumentException
+     * @expectedException \Github\Exception\InvalidArgumentException
      */
     public function shouldNotRemoveEmailsWhenAreNotPass()
     {
@@ -101,7 +99,7 @@ public function shouldAddEmails()
 
     /**
      * @test
-     * @expectedException Github\Exception\InvalidArgumentException
+     * @expectedException \Github\Exception\InvalidArgumentException
      */
     public function shouldNotAddEmailsWhenAreNotPass()
     {

diff --git a/test/Github/Tests/Api/CurrentUser/FollowersTest.php b/test/Github/Tests/Api/CurrentUser/FollowersTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class FollowersTest extends TestCase
 {
     /**

diff --git a/test/Github/Tests/Api/CurrentUser/StarringTest.php b/test/Github/Tests/Api/CurrentUser/StarringTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class StarringTest extends TestCase
 {
     /**

diff --git a/test/Github/Tests/Api/CurrentUser/WatchersTest.php b/test/Github/Tests/Api/CurrentUser/WatchersTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class WatchersTest extends TestCase
 {
     /**

diff --git a/test/Github/Tests/Api/CurrentUserTest.php b/test/Github/Tests/Api/CurrentUserTest.php
@@ -133,7 +133,7 @@ public function shouldGetWatchersApiObject()
 
         $this->assertInstanceOf('Github\Api\CurrentUser\Watchers', $api->watchers());
     }
-    
+
     /**
      * @test
      */

diff --git a/test/Github/Tests/Api/DeploymentTest.php b/test/Github/Tests/Api/DeploymentTest.php
@@ -63,7 +63,7 @@ public function shouldCreateStatusUpdate()
 
     /**
      * @test
-     * @expectedException GitHub\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldRejectStatusUpdateWithoutStateField()
     {

diff --git a/test/Github/Tests/Api/GistsTest.php b/test/Github/Tests/Api/GistsTest.php
@@ -112,7 +112,7 @@ public function shouldListGistForks()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateGistWithoutFile()
     {

diff --git a/test/Github/Tests/Api/GitData/BlobsTest.php b/test/Github/Tests/Api/GitData/BlobsTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class BlobsTest extends TestCase
 {
     /**
@@ -69,7 +67,7 @@ public function shouldCreateBlob()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateBlobWithoutEncoding()
     {
@@ -84,7 +82,7 @@ public function shouldNotCreateBlobWithoutEncoding()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateBlobWithoutContent()
     {

diff --git a/test/Github/Tests/Api/GitData/CommitsTest.php b/test/Github/Tests/Api/GitData/CommitsTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class CommitsTest extends TestCase
 {
     /**
@@ -41,7 +39,7 @@ public function shouldCreateCommit()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateCommitWithoutMessageParam()
     {
@@ -56,7 +54,7 @@ public function shouldNotCreateCommitWithoutMessageParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateCommitWithoutTreeParam()
     {
@@ -71,7 +69,7 @@ public function shouldNotCreateCommitWithoutTreeParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateCommitWithoutParentsParam()
     {

diff --git a/test/Github/Tests/Api/GitData/ReferencesTest.php b/test/Github/Tests/Api/GitData/ReferencesTest.php
@@ -119,7 +119,7 @@ public function shouldCreateReference()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateReferenceWithoutShaParam()
     {
@@ -134,7 +134,7 @@ public function shouldNotCreateReferenceWithoutShaParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateReferenceWithoutRefsParam()
     {
@@ -166,7 +166,7 @@ public function shouldUpdateReference()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNoUpdateReferenceWithoutSha()
     {

diff --git a/test/Github/Tests/Api/GitData/TagsTest.php b/test/Github/Tests/Api/GitData/TagsTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class TagsTest extends TestCase
 {
     /**
@@ -67,7 +65,7 @@ public function shouldCreateTag()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTagWithoutMessageParam()
     {
@@ -91,7 +89,7 @@ public function shouldNotCreateTagWithoutMessageParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTagWithoutTaggerParam()
     {
@@ -111,7 +109,7 @@ public function shouldNotCreateTagWithoutTaggerParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTagWithoutTaggerNameParam()
     {
@@ -135,7 +133,7 @@ public function shouldNotCreateTagWithoutTaggerNameParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTagWithoutTaggerEmailParam()
     {
@@ -159,7 +157,7 @@ public function shouldNotCreateTagWithoutTaggerEmailParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTagWithoutTaggerDateParam()
     {
@@ -183,7 +181,7 @@ public function shouldNotCreateTagWithoutTaggerDateParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTagWithoutTagParam()
     {
@@ -207,7 +205,7 @@ public function shouldNotCreateTagWithoutTagParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTagWithoutObjectParam()
     {
@@ -231,7 +229,7 @@ public function shouldNotCreateTagWithoutObjectParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTagWithoutTypeParam()
     {

diff --git a/test/Github/Tests/Api/GitData/TreesTest.php b/test/Github/Tests/Api/GitData/TreesTest.php
@@ -2,8 +2,6 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class TreesTest extends TestCase
 {
     /**
@@ -88,7 +86,7 @@ public function shouldCreateTreeUsingContent()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTreeWithoutShaAndContentParam()
     {
@@ -109,7 +107,7 @@ public function shouldNotCreateTreeWithoutShaAndContentParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTreeWithoutPathParam()
     {
@@ -130,7 +128,7 @@ public function shouldNotCreateTreeWithoutPathParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTreeWithoutModeParam()
     {
@@ -151,7 +149,7 @@ public function shouldNotCreateTreeWithoutModeParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTreeWithoutTypeParam()
     {
@@ -172,7 +170,7 @@ public function shouldNotCreateTreeWithoutTypeParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTreeWithoutTreeParam()
     {
@@ -187,7 +185,7 @@ public function shouldNotCreateTreeWithoutTreeParam()
 
     /**
      * @test
-     * @expectedException Github\Exception\MissingArgumentException
+     * @expectedException \Github\Exception\MissingArgumentException
      */
     public function shouldNotCreateTreeWhenTreeParamIsNotArray()
     {
-Original file line number
+Diff line change
@@ Expand Up @@
             return $this->put($url, $parameters);
         }
         /**
          * Deletes a file from a repository.
          *
@@ Expand Down @@