Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit a52a92a disables all subscribers #267

Closed
tamcy opened this issue Nov 19, 2015 · 3 comments
Closed

Commit a52a92a disables all subscribers #267

tamcy opened this issue Nov 19, 2015 · 3 comments

Comments

@tamcy
Copy link

tamcy commented Nov 19, 2015

According to the updated documentation, commit a52a92a intended to make all configurations enabled by default when the root node knp_doctrine_behaviors is empty. However, when tested on Symfony 2.7.6, the actual behavior is that all behaviors are disabled by default. Looks like the treatNullLike([... => true ]) in Configuration class has no effect. Can anyone verify this behavior? Thanks.
@docteurklein
Copy link
Contributor

ping @NiR-

@Mondane
Copy link
Contributor

Mondane commented Mar 8, 2016

Mm, this might actually be true as I've just tried to convert the deprecated method to the new one in my project. After the conversion, nothing worked anymore. See #263 and #272 .

akerouanton pushed a commit to akerouanton/DoctrineBehaviors that referenced this issue Mar 9, 2016
Fix KnpLabs#267: if no config specified all behaviors are enabled
99c907f
@akerouanton
Copy link
Contributor

Thanks @Mondane & @tamcy for the report. I've pushed a fix for this BC break. It will be merged soon.

akerouanton pushed a commit to akerouanton/DoctrineBehaviors that referenced this issue Mar 9, 2016
Fix BC break: if no config specified all behaviors are enabled
f7dc13e 
This commit fixes KnpLabs#297, KnpLabs#292, KnpLabs#286, KnpLabs#281, KnpLabs#272, KnpLabs#270, KnpLabs#267.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@docteurklein @akerouanton @tamcy @Mondane