Do not use filepath.Separator for splitting URLs

KnVerey · Jan 24, 2023 · 8b21844 · 8b21844
1 parent d315600
commit 8b21844
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/api/internal/git/repospec.go b/api/internal/git/repospec.go
@@ -79,7 +79,7 @@ const (
 	refQuery         = "?ref="
 	gitSuffix        = ".git"
 	gitRootDelimiter = "_git/"
-	pathSeparator    = string(filepath.Separator)
+	pathSeparator    = "/" // do not use filepath.Separator, as this is a URL
 )
 
 // NewRepoSpecFromURL parses git-like urls.
@@ -198,8 +198,8 @@ func tryDefaultLengthSplit(n string, defaultSegmentLength int) (string, string,
 }
 
 func kustRootPathExitsRepo(kustRootPath string) bool {
-	cleanedPath := filepath.Clean(strings.TrimPrefix(kustRootPath, pathSeparator))
-	pathElements := strings.Split(cleanedPath, pathSeparator)
+	cleanedPath := filepath.Clean(strings.TrimPrefix(kustRootPath, string(filepath.Separator)))
+	pathElements := strings.Split(cleanedPath, string(filepath.Separator))
 	return len(pathElements) > 0 &&
 		pathElements[0] == filesys.ParentDir
 }