mypy - Argument "api_gateway_base_path" to "Mangum" has incompatible type "str"; expected "Dict[str, Any]" #220

relsunkaev · 2022-01-11T18:50:36Z

Removed handler_kwargs from adapter and handler constructors in favor of an explicit api_gateway_base_path parameter (the only parameter handler_kwargs could have)
Removed unnecessary ContextManager typing on lifespan_cycle in adapter.py
Changed BaseRequest.scope to a property (formerly a function) for consistency with child classes
Scope, being a MutableMapping technically has no .copy() as part of its protocol (collections generally don't). Using copy.copy() in protocols.websockets.run() to reflect that
Additional typing

Closes #201

…anged `BaseRequest.scope` to a property (formerly a method) for consistency with child classes;

jordaneremieff · 2022-01-20T06:02:29Z

Thanks @relsunkaev, I think this is good to merge. Before I do, I wanted to see if you might also remove the handler_kwargs and kwargs included in the handler class constructors? Seems like these aren't used anywhere.

If you're not sure about what I mean about the kwargs then I can alternatively just merge this and remove those later.

relsunkaev · 2022-01-20T07:14:29Z

Yeah, I noticed the same thing but didn't look further into it since I didn't know if there was something planned for that. I'll add it to the PR.

jordaneremieff · 2022-01-20T07:30:19Z

@relsunkaev thanks. I added a comment to the (now closed) issue here discussing the kwargs validation more generally.

There is likely some more work to be done beyond just removing handler_kwargs and kwargs, but that'd be outside of the scope of this PR because we'd be committing to handling all existing and potential specific handler parameters in a single, consistent way going forward.

`api_gateway_base_path` is now an explict param; Fixed two exception entries on lifespan config; Added test for default `api_gateway_base_path` value;

relsunkaev · 2022-01-20T21:43:09Z

Just updated my PR with the changes.

mangum/adapter.py

mangum/handlers/aws_alb.py

mangum/protocols/lifespan.py

mangum/handlers/abstract_handler.py

mangum/protocols/http.py

Created `QueryParams` TypeAlias in `types.py`; `api_gateway_base_path` is now a positional arg in handlers; Fixed tests to reflect the above; Made imports consistent to use `from`; Cleaned up some code to make Pylance happy; Fixed setting InitVar in `WebSocket`;

jordaneremieff · 2022-01-22T11:12:57Z

@relsunkaev looks good, thanks!

…#220) * Fixed typing in adapter.py; Added more explicit types some places; Changed `BaseRequest.scope` to a property (formerly a method) for consistency with child classes; * Removed `handler_kwargs`; `api_gateway_base_path` is now an explict param; Fixed two exception entries on lifespan config; Added test for default `api_gateway_base_path` value; * Fixed `AwsApiGateway` missing default for `api_gateway_base_path`; * Added `api_gateway_base_path` param in `test_abstract_handler`; * Removed `Optional` import from `abstract_handler`; * Removed class attributes from `Mangum`; Created `QueryParams` TypeAlias in `types.py`; `api_gateway_base_path` is now a positional arg in handlers; Fixed tests to reflect the above; Made imports consistent to use `from`; Cleaned up some code to make Pylance happy; Fixed setting InitVar in `WebSocket`; * Fixed linting error; * Fixed coverage; * Removed unused import; Co-authored-by: Ramazan Elsunkaev <ramazan@up-linq.com>

Ramazan Elsunkaev and others added 2 commits January 10, 2022 18:52

Fixed typing in adapter.py; Added more explicit types some places; Ch…

8c500c0

…anged `BaseRequest.scope` to a property (formerly a method) for consistency with child classes;

Merge branch 'jordaneremieff:main' into main

80f153f

jordaneremieff mentioned this pull request Jan 20, 2022

Validate kwargs more strictly #172

Closed

Removed handler_kwargs;

ee9d2d1

`api_gateway_base_path` is now an explict param; Fixed two exception entries on lifespan config; Added test for default `api_gateway_base_path` value;

Ramazan Elsunkaev and others added 3 commits January 20, 2022 18:32

Fixed AwsApiGateway missing default for api_gateway_base_path;

165a850

Added api_gateway_base_path param in test_abstract_handler;

d0a62b6

Removed Optional import from abstract_handler;

49a41be