Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Incorrect interface for insertNextPoint on vtkPoints #3048

Closed
ramonemiliani93 opened this issue Mar 27, 2024 · 1 comment · Fixed by #3049
Closed

[Bug] Incorrect interface for insertNextPoint on vtkPoints #3048

ramonemiliani93 opened this issue Mar 27, 2024 · 1 comment · Fixed by #3049
Labels
released Automated label type: bug 🐞 Errors in functionality

Comments

@ramonemiliani93
Copy link
Contributor

Bug description

The insertNextPoint calls the parent class insertNextTuple method which returns the idx of the inserted point.

Steps to reproduce

import vtkPoints from "@kitware/vtk.js/Common/Core/Points";

const points = vtkPoints.newInstance();
const idx = points.insertNextPoint(1, 2, 3)  // idx exists but warns void function return value is used

Detailed Behavior

No response

Expected Behavior

Should not warn about returned idx

Environment

  • vtk.js version: latest
  • Browsers: chrome
  • OS: MacOS
@ramonemiliani93 ramonemiliani93 added the type: bug 🐞 Errors in functionality label Mar 27, 2024
ramonemiliani93 pushed a commit to ramonemiliani93/vtk-js that referenced this issue Mar 27, 2024
fix(type): fix type returned when inserting a point
9a735ec 
fix Kitware#3048
@ramonemiliani93 ramonemiliani93 mentioned this issue Mar 27, 2024
Merged
5 tasks
ramonemiliani93 pushed a commit to ramonemiliani93/vtk-js that referenced this issue Mar 27, 2024
fix(type): update the returned type by insertNextPoint
d2628dd 
fix Kitware#3048
ramonemiliani93 pushed a commit to ramonemiliani93/vtk-js that referenced this issue Mar 27, 2024
fix(type): fixes the returned type of insertNextPoint
3155aaf 
fix Kitware#3048
github-merge-queue bot pushed a commit that referenced this issue May 30, 2024
@floryst
fix(type): fixes the returned type of insertNextPoint
952a26f 
fix #3048
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 30.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Automated label type: bug 🐞 Errors in functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(type): fix type returned when inserting a point ramonemiliani93/vtk-js
1 participant
@ramonemiliani93