-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ability to limit request size and connection count #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ianpartridge
reviewed
Oct 7, 2019
ianpartridge
reviewed
Oct 8, 2019
ianpartridge
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a
requestSizeLimit
(maximum bytes for a request, including the headers) andconnectionLimit
on total number of concurrent connections.This is exposed through a new API in Kitura for the user to set these options upon registering a server: Kitura/Kitura#1481
Example usage from Kitura is as follows:
If you do not specify either of the parameters, or do not specify a
ServerOptions
at all, then default values are used. The defaults are defined as constantsServerOptions.defaultRequestSizeLimit
andServerOptions.defaultConnectionLimit
.If a client sends a request that exceeds the limit, then they are immediately sent an
HTTP/1.1 413 Request Entity Too Large
and the connection is closed.If a client attempts to connect, but we are already at the connection limit, they are immediately sent an
HTTP/1.1 503 Service Unavailable
and the connection is closed.These responses can be further customized by supplying
requestSizeResponseGenerator
andconnectionResponseGenerator
closures, which are passed anInt
(the limit that was exceeded) and aString
(the hostname and port of the socket), and return anHTTPStatusCode
and aString
that is a plaintext message to be returned to the client. The default responses are again defined as constantsdefaultRequestSizeResponseGenerator
anddefaultConnectionResponseGenerator
.Some issues I'm aware of:
keepAlive
andallowPortReuse
onKitura.addHTTPServer
which could be rolled into this new options struct.Motivation and Context
See: Kitura/Kitura#1384
How Has This Been Tested?
Tests have been added as part of Kitura/Kitura#1481
Checklist: