tests: Use ephemeral ports by default

[pushkarnk]

Instead of restricting the ephemeral port range to accommodate port numbers in an Int16 (a known limitation of ClientRequest), we can cast Int16s to UInt16s and vice versa. This removes the need to have the USE_EPHEMERAL_PORTS compiler flag and the script that issues commands to restrict the ephemeral port range.

[codecov-io]

Codecov Report

Merging #140 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   67.09%   67.09%   -0.01%     
==========================================
  Files          20       20              
  Lines        1252     1255       +3     
==========================================
+ Hits          840      842       +2     
- Misses        412      413       +1

Flag	Coverage Δ
#KituraNet	67.09% <50%> (-0.01%)	⬇️

Impacted Files	Coverage Δ
Sources/KituraNet/ClientRequest.swift	69.1% <50%> (-0.03%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adf865...f1283a2. Read the comment docs.

[djones6]

Nice solution!

[djones6]

You also need to change func parse() to convert a parsed port number, ie:

        if let port = url.port {
-            options.append(.port(Int16(port)))
+            options.append(.port(Int16(bitPattern: UInt16(port))))
        }

[pushkarnk]

Thanks to @weissi for suggesting this!

[pushkarnk]

Thanks for the review @djones6 I've pushed a commit with the change you suggested.

[djones6]

@pushkarnk This looks good to me. Once this is merged and tagged, you can update Kitura/Kitura#1382 accordingly.

(The Kitura-net equivalent, Kitura/Kitura-net#285, has been merged and tagged).