Support corrupt logs produced by some 17.7 MSBuilds #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around bad binlogs produced by dotnet/msbuild#8971 by probing for the zip header that will be the known first bytes of the blob. Co-authored-by: MichalPavlik <mipavlik@microsoft.com>
|
@MichalPavlik can you give this a once-over to see if it matches what we were talking about offline? |
|
Have we tested this with the corrupt binlogs and the regular binlogs? |
|
Yes, it Works On My Machine™️. I've tried with binlogs from current dogfood VS builds, binlogs from the PR with the fix, and binlogs from production 17.6 builds, and verified that they all had many .targets files in the "files" tab. |
KirillOsenkov
approved these changes
Jul 25, 2023
Yes Rainer, it's exactly what I proposed. Thanks for mitigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around bad binlogs produced by dotnet/msbuild#8971 by probing for the zip header that will be the known first bytes of the blob.