Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Dither render setting adds unwanted noise to composited bakes. #93

Closed
2 tasks done
KirilStrezikozin opened this issue Jul 30, 2024 · 0 comments · Fixed by #97
Closed
2 tasks done

BUG: Dither render setting adds unwanted noise to composited bakes. #93

KirilStrezikozin opened this issue Jul 30, 2024 · 0 comments · Fixed by #97
Assignees
Labels
bug your old lawnmower broke down solved How could you? GPT helped?

Comments

@KirilStrezikozin
Copy link
Owner

KirilStrezikozin commented Jul 30, 2024

This bug report is:

  • not a duplicate
  • fixed

Describe the bug
Dither Intensity property in the Render Post Processing settings affects bake results that go through the Compositor (denoising, channel pack, decal bake, compositor nodes). It adds unwanted dithering noise that is somewhat noticeable in areas dominated by a single color.

To Reproduce
Steps to reproduce the behavior:

  1. Set up a compositing node tree without nodes besides connected Render Layers into the final Composite node.
  2. Tick 'Use Compositor` in BakeMaster Color Management settings.
  3. Bake an ID map using the Hue color generation algorithm.
  4. Zoom in on the baked ID map and see dithering noise.

Expected behavior
Subtle dithering noise does not break ID maps and is barely noticeable. Still, it is visually confusing to see maps have a noisy post-processing effect. Dithering Intensity must be set to 0 before baking.

Screenshots
Zoomed-in area of a purple segment on ID map:
image

Desktop (please complete the following information):

  • OS Arch Linux
  • Blender Version 4.1.0
  • BakeMaster Version 2.6.3

Additional context
Render Post Processing settings include the Dither Intensity property:

Dither Intensity: Amount of dithering noise added to the rendered image to break up banding.

BakeMaster resets it to the default value of 1 before each bake:

context.scene.render.dither_intensity = 1.0
...

It should be 0 instead.

@KirilStrezikozin KirilStrezikozin added bug your old lawnmower broke down in progress All night I stay not sleeping because I'm thinking about this labels Jul 30, 2024
@KirilStrezikozin KirilStrezikozin self-assigned this Jul 30, 2024
@KirilStrezikozin KirilStrezikozin added solved How could you? GPT helped? close on release done here, but let's wait for the release and removed in progress All night I stay not sleeping because I'm thinking about this labels Jul 30, 2024
@KirilStrezikozin KirilStrezikozin added this to the BakeMaster 2.7.0 milestone Jul 30, 2024
@KirilStrezikozin KirilStrezikozin removed the close on release done here, but let's wait for the release label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug your old lawnmower broke down solved How could you? GPT helped?
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant