Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Several default values have hard limits while Blender has soft #65

Closed
2 tasks done
KirilStrezikozin opened this issue Feb 4, 2024 · 1 comment
Closed
2 tasks done
Assignees
Labels
bug your old lawnmower broke down solved How could you? GPT helped?

Comments

@KirilStrezikozin
Copy link
Owner

KirilStrezikozin commented Feb 4, 2024

This bug report is:

  • not a duplicate
  • fixed

Describe the bug
@marcovivirito reported on Discord:

Can't set extrusion value higher than 1 in BakeMaster:
image
Although Blender allows values like 3m for extrusion:
image

To Reproduce
Steps to reproduce the behavior:

  1. Add an object to BakeMaster
  2. Go to High to Lowpoly panel
  3. Scroll down to where the extrusion property is
  4. Try to set a value higher than 1
  5. See that 1 is the hard upper limit.

Expected behavior
Extrusion value is passed to Blender Bake from BakeMaster. Therefore, BakeMaster's extrusion should allow the same values as Blender's default extrusion.

Desktop (please complete the following information):

  • OS Any
  • Blender 4.0
  • BakeMaster 2.6.0a4 (or 2.6.0a3)

Additional context
So far I've also found that BakeMaster's margin property has a hard limit of 64, although Blender's one has a soft limit of 64.

@KirilStrezikozin KirilStrezikozin added the bug your old lawnmower broke down label Feb 4, 2024
@KirilStrezikozin KirilStrezikozin self-assigned this Feb 4, 2024
@KirilStrezikozin KirilStrezikozin added this to the BakeMaster 2.6.0 milestone Feb 4, 2024
@KirilStrezikozin KirilStrezikozin added the in progress All night I stay not sleeping because I'm thinking about this label Feb 4, 2024
@KirilStrezikozin
Copy link
Owner Author

List of all changes:

  • map extrusion (1.0m is not soft_max, max is infinity)
  • map max ray distance (1.0m is not soft_max, max is infinity)
  • map res height (removed max of 65536)
  • map res width (removed max of 65536)
  • map margin (64 is not soft_max, max is 32767)
  • map ao brightness (-100 and 100 are now soft_min and soft_max)
  • map ao contrast (-100 and 100 are now soft_min and soft_max)
  • map curvature gamma (0.001 is not soft_min, min became 0, max of 10 removed and is now soft_max)
  • object extrusion (1.0m is not soft_max, max is infinity)
  • object max ray distance (1.0m is not soft_max, max is infinity)
  • object auto unwrap angle (89 is now soft_max, max became 90)
  • object res height (removed max of 65536)
  • object res width (removed max of 65536)
  • object margin (64 is not soft_max, max is 32767)

@KirilStrezikozin KirilStrezikozin added needs testing wow does it even work? solved How could you? GPT helped? close on release done here, but let's wait for the release migrate: dev->public I'm doing cps now until I manage my repos better. and removed in progress All night I stay not sleeping because I'm thinking about this needs testing wow does it even work? labels Feb 4, 2024
@KirilStrezikozin KirilStrezikozin removed migrate: dev->public I'm doing cps now until I manage my repos better. close on release done here, but let's wait for the release labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug your old lawnmower broke down solved How could you? GPT helped?
Projects
None yet
Development

No branches or pull requests

1 participant