Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Add fetchFunc option to client constructor #1097

Merged
merged 6 commits into from
Aug 4, 2021
Merged

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Jul 30, 2021

@leplatrem leplatrem requested a review from dstaley July 30, 2021 12:09
@github-actions
Copy link

github-actions bot commented Jul 30, 2021

Size Change: +175 B (0%)

Total Size: 40.9 kB

ℹ️ View Unchanged
Filename Size Change
dist/kinto-http.min.js 9.09 kB +31 B (0%)
dist/kinto-http.node.js 15.2 kB +78 B (+1%)
dist/moz-kinto-http-client.js 16.7 kB +66 B (0%)

compressed-size-action

@leplatrem leplatrem force-pushed the introduce-fetch-hook branch from 15836d7 to 6f484ca Compare July 30, 2021 12:14
@leplatrem leplatrem force-pushed the introduce-fetch-hook branch from 6f484ca to 5579140 Compare July 30, 2021 13:23
leplatrem and others added 4 commits July 30, 2021 15:28
Without this the exported symbol `KintoHttpClient` is not reachable.
This build has change that is responsible of this regression:

```diff

 (function (global, factory) {
     typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
     typeof define === 'function' && define.amd ? define(factory) :
-    (global = global || self, global.KintoHttpClient = factory());
+    (global = typeof globalThis !== 'undefined' ? globalThis : global || self, global.KintoHttpClient = factory());
 }(this, (function () { 'use strict';

```
@leplatrem leplatrem merged commit b6fc075 into master Aug 4, 2021
@leplatrem leplatrem deleted the introduce-fetch-hook branch August 4, 2021 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants