fix: trim whitespace from global filepath #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On POSIX systems, files are supposed to end with line breaks. Many text editors will uphold this rule and place a newline at the end of the standardsettings.global file, which prevents it from being loaded because the filepath should not end with a newline.
KingContaria
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On POSIX systems, text files are supposed to end with line breaks. Many text editors will uphold this rule and place a newline at the end of the
standardsettings.globalfile. This prevents StandardSettings from loading the global JSON file, since it thinks the filepath ends with a line break when it shouldn't.It might be better to read only the first line from the file or only remove trailing
\rand\ncharacters? Feel free to let me know if you'd prefer this was implemented in a different way.