Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path when user provides tshark_path using LiveCapture. #562

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

miaotony
Copy link
Contributor

@miaotony miaotony commented Jul 3, 2022

When I provided a tshark_path parameter like D:\\Program Files\\Wireshark\\tshark.exe, using LiveCapture called tshark in Dumpcap subprocess, and nothing captured.

图片

Therefore I tried to run it on a Linux machine which tshark was in the default path, the program captured successfully.
And you can see that the program in Dumpcap subprocess is dumpcap.

图片

After carefully reviewing the source code, I find that when user provides his own tshark_path, the process_name will not be spliced to path, which is the bug of this problem.

The commit 85adafa did not solve this bug, so in this PR I try to fix it.

A user can provide a path like D:\\Program Files\\Wireshark\\tshark.exe or D:\\Program Files\\Wireshark, and process_name will be joined. It is also feasible for Linux.

@KimiNewt KimiNewt merged commit d61aaf4 into KimiNewt:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants