Fix path when user provides tshark_path
using LiveCapture
.
#562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I provided a
tshark_path
parameter likeD:\\Program Files\\Wireshark\\tshark.exe
, usingLiveCapture
called tshark in Dumpcap subprocess, and nothing captured.Therefore I tried to run it on a Linux machine which tshark was in the default path, the program captured successfully.
And you can see that the program in Dumpcap subprocess is
dumpcap
.After carefully reviewing the source code, I find that when user provides his own
tshark_path
, theprocess_name
will not be spliced topath
, which is the bug of this problem.The commit 85adafa did not solve this bug, so in this PR I try to fix it.
A user can provide a path like
D:\\Program Files\\Wireshark\\tshark.exe
orD:\\Program Files\\Wireshark
, andprocess_name
will be joined. It is also feasible for Linux.