Make pool allocations more explicit #3387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f04b514 to
70493be
Compare
This removes the ability for some classes to be implicitly allocated using the pool allocator. Now NewPoolObject should be used to explicitly allocate any object using the pool allocator. Some other things this change does: - Remove some of the NewPool* non-generic functions, replacing them with a single "make_unique" style function. - Existing pointers allocated with the standard allocator are replaced with smart pointers. Related to KhronosGroup#3123.
70493be to
2d6da45
Compare
|
I think we're going to take a different approach here, plus this isn't really a priority at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ability for some classes to be implicitly allocated using the pool allocator. Now NewPoolObject should be used to explicitly allocate any object using the pool allocator.
Some other things this change does: