syncval: Split Device and Instance ValidationObjects #9235
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 347528. |
This is the start of splitting class ValidationObject into separate Device and Instance classes. Syncval has nothing happening at Instance level so it gets to go first. Once all the leaf classes are split, ValidationStateTracker and ValidationObject can be split. This seems backwards but allows it to happen incrementally rather than in 1 giant PR
e2be564 to
39ad9a7
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 347543. |
|
CI Vulkan-ValidationLayers build # 18711 running. |
| @@ -27,6 +27,14 @@ | |||
| #include "sync/sync_stats.h" | |||
| #include "sync/sync_submit.h" | |||
|
|
|||
| namespace syncval { | |||
| // sync validation has no instance-level functionality | |||
| class Instance : public ValidationStateTracker { | |||
There was a problem hiding this comment.
Got confused that comment says no instance functionality but also create Instance class. In what direction this is going to evolve? Do we need at least empty Instance class?
There was a problem hiding this comment.
There will be a couple of phases:
- First this will inherit from the Instance object of the state tracker, something like
vvl::state::Instance - Then there will be a common state tracker and I think this class will go away. Since syncval does nothing here, your 'device' level objects (SyncValidators) will just point at the shared state trackers Device and Instance objects
There was a problem hiding this comment.
Other validation types will still have to have Instance classes so that they can do their current instance level functionality.
|
CI Vulkan-ValidationLayers build # 18711 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 348126. |
|
CI Vulkan-ValidationLayers build # 18728 running. |
|
CI Vulkan-ValidationLayers build # 18728 passed. |
This is the start of splitting class ValidationObject into separate Device and Instance classes. Syncval has nothing happening at Instance level so it gets to go first. Once all the leaf classes are split, ValidationStateTracker and ValidationObject can be split. This seems backwards but allows it to happen incrementally rather than in 1 giant PR