Remove RTP feature request from ray_queries #908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ray_queries
sample requests the RTP feature support from the GPU, although I can't see why this is done as the RQ extension has no dependency on the RTP extension, and RTP isn't used in the sample. Unsurprisingly removing it has no effect on the devices I've tried it on.This isn't an issue on desktop GPUs where RTP and RQ are always supported together, but on mobile many device manufacturers only support RQ. Interestingly on the device I tested it on, a Vivo X90 Pro, the hardware supports RTP but it's been disabled at the driver level - I only can assume the sample still works because that effort was botched.
Tested on:
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: