Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RTP feature request from ray_queries #908

Merged

Conversation

cmannett85-arm
Copy link
Contributor

Description

The ray_queries sample requests the RTP feature support from the GPU, although I can't see why this is done as the RQ extension has no dependency on the RTP extension, and RTP isn't used in the sample. Unsurprisingly removing it has no effect on the devices I've tried it on.

This isn't an issue on desktop GPUs where RTP and RQ are always supported together, but on mobile many device manufacturers only support RQ. Interestingly on the device I tested it on, a Vivo X90 Pro, the hardware supports RTP but it's been disabled at the driver level - I only can assume the sample still works because that effort was botched.

Tested on:

  • Vivo X90 Pro (Mali-G715-Immortalis MC11)
  • NVidia 3090 FE (535.154.05, Linux)

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2024

CLA assistant check
All committers have signed the CLA.

@SaschaWillems
Copy link
Collaborator

Thanks for spotting this. You're 100% right, the ray tracing pipeline feature is not required when only using ray queries.

@SaschaWillems SaschaWillems self-requested a review February 12, 2024 09:33
SaschaWillems
SaschaWillems previously approved these changes Feb 12, 2024
@cmannett85-arm
Copy link
Contributor Author

The copyright checker is failing, but I've got this:

/* Copyright (c) 2021-2023, Holochip Corporation
 * Copyright (c) 2024, Arm Limited and Contributors

Am I supposed to update the other company's copyright dates too?

@SaschaWillems
Copy link
Collaborator

Yeah, that's sadly a limitation of the copyright checker. You also need to update the existing copyright.

@tomadamatkinson : Maybe that's something we can fix? I often have the same problem.

@tomadamatkinson
Copy link
Collaborator

@cmannett85-arm currently yes. We've had the same copyright check since the beginning.

I think technically we don't require copyright in a source file. As copyright is implied. We would need to decide as a WG on our copyright practices. Currently it is to bump all copyright owners if a file has changed.

There is a helper script here ./scripts/copyright.py main --fix which will automatically sort out the copyright for you.

@marty-johnson59 marty-johnson59 merged commit 5177ee6 into KhronosGroup:main Feb 12, 2024
24 checks passed
@cmannett85-arm cmannett85-arm deleted the remove_rtp_from_rq branch February 12, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants