-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sccache usage in Windows CI builds #897
Conversation
@gpx1000 You mentioned having trouble getting sccache working in Windows CI builds. I was able to track it down after I noticed something odd in the beginning of the CMake config. The basic issue was twofold...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks like this cuts the Windows build down from ~30minutes to ~7minutes in the CI
It occurred to me that I should revert the change adding messaging about lack of ccache or sccache since they don't work with the most commonly used Windows generators. I could gate them behind a |
I always kept it in Ninja build for Windows as I wanted to ensure the windows build system was using at least NMake. SCCache was supposed to work with NMake but I never got that working right. I think it's far better to just bite the bullet and use Ninja as you have here. I don't think at first blush that the macos build failure in CI is due to the changes here. lemme know if you need help changing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this PR. Works fine for me on Windows 11 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; thanks for the contribution!
Description
This corrects a couple problems preventing the Windows CI builds from using sccache.
Fix for #896 and reduces windows build significantly.