Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hello_triangle_1_3 debug_callback compilation warning #1280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gary-sweet
Copy link
Contributor

Description

The debug_callback() in hello_triangle_1_3 was incorrectly checking for a preformance bit in the severity flags, when it should have been the types flags.

This resulted in:

samples/api/hello_triangle_1_3/hello_triangle_1_3.cpp: In function 'VkBool32 debug_callback(VkDebugUtilsMessageSeverityFlagBitsEXT, VkDebugUtilsMessageTypeFlagsEXT, const VkDebugUtilsMessengerCallbackDataEXT*, void*)': samples/api/hello_triangle_1_3/hello_triangle_1_3.cpp:45:35: warning: bitwise operation between different enumeration types 'VkDebugUtilsMessageSeverityFlagBitsEXT' and 'VkDebugUtilsMessageTypeFlagBitsEXT' is deprecated [-Wdeprecated-enum-enum-conversion]
   45 |         else if (message_severity & VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT)
      |                  ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions - just tested on Linux

The debug_callback was incorrectly checking for a preformance bit
in the severity flags, when it should have been the types flags.

This resulted in:

samples/api/hello_triangle_1_3/hello_triangle_1_3.cpp: In function 'VkBool32 debug_callback(VkDebugUtilsMessageSeverityFlagBitsEXT, VkDebugUtilsMessageTypeFlagsEXT, const VkDebugUtilsMessengerCallbackDataEXT*, void*)':
samples/api/hello_triangle_1_3/hello_triangle_1_3.cpp:45:35: warning: bitwise operation between different enumeration types 'VkDebugUtilsMessageSeverityFlagBitsEXT' and 'VkDebugUtilsMessageTypeFlagBitsEXT' is deprecated [-Wdeprecated-enum-enum-conversion]
   45 |         else if (message_severity & VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT)
      |                  ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@gary-sweet gary-sweet requested a review from a team February 25, 2025 11:36
@SaschaWillems SaschaWillems self-requested a review February 25, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants