Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of samples dynamic rendering local read and host image copy #1155

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

brimston3
Copy link
Contributor

@brimston3 brimston3 commented Sep 6, 2024

Description

PR #887 predated vkb::core::CppBuffer merge, change type used to BufferC in samples dynamic rendering local read and host image copy.

Fixes #1154.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

PR KhronosGroup#887 predated vkb::core::CppBuffer merge, change type used to BufferC
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@SaschaWillems
Copy link
Collaborator

Thanks for catching this. Very unfortunate, maybe we need to rethink how we merge large framework changes to avoid this.

Will merge once CI has run.

@SaschaWillems
Copy link
Collaborator

@brimston3 : Bummer. It fails with clang format. Can you fix that? If not I could take a look, but might take a while.

@brimston3
Copy link
Contributor Author

@SaschaWillems My mistake, I've run the formatter now and committed the changes.

@SaschaWillems
Copy link
Collaborator

Thank you very much 👍🏻

@SaschaWillems SaschaWillems merged commit 6227cc2 into KhronosGroup:main Sep 7, 2024
23 checks passed
@SaschaWillems SaschaWillems added the urgent Need to resolve as soon as possible label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Need to resolve as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samples dynamic rendering local read and host image copy fail to compile (vkb::core::Buffer merge)
3 participants