Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -fpreview-breaking-changes flag to conformance mode for DPCPP #829

Conversation

steffenlarsen
Copy link
Contributor

The SYCL2020_CONFORMANT_APIS in DPCPP is being deprecated in favor of -fpreview-breaking-changes option. This patch adds this new option when conformant APIs are enabled for DPCPP while keeping the preprocessor macro for now.

The SYCL2020_CONFORMANT_APIS in DPCPP is being deprecated in favor of
-fpreview-breaking-changes option. This patch adds this new option when
conformant APIs are enabled for DPCPP while keeping the preprocessor
macro for now.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from bader as a code owner November 7, 2023 12:35
@steffenlarsen
Copy link
Contributor Author

This patch will need a DPC++ version bump.

@bader
Copy link
Contributor

bader commented Nov 7, 2023

This patch will need a DPC++ version bump.

@steffenlarsen, will you uplift the DPC++ version?

@bader
Copy link
Contributor

bader commented Nov 9, 2023

This patch will need a DPC++ version bump.

@steffenlarsen, will you uplift the DPC++ version?

Reminder: to test the "DPC++ version uplift", you will need to create a branch https://github.com/KhronosGroup/SYCL-CTS/ repository directly.

Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bader bader merged commit bb20fb6 into KhronosGroup:SYCL-2020 Nov 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants