Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in atomic_ref test names #826

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

frasercrmck
Copy link
Contributor

I'm assuming these are typos.

There are some inconsistencies about how we style the test names for ostensibly the same operations: see tests covering one operator (atomic_ref::operator) vs those that cover two (atomic_ref operator/operator - no colons). I see why it was done, but the inconsistency is noticeable.

@frasercrmck frasercrmck requested a review from a team as a code owner November 2, 2023 16:52
@bader bader added the help wanted Extra attention is needed label Nov 2, 2023
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why we need more code introspection in future C++ to avoid writing such boilerplate description manually. :-)

@bader bader merged commit b4349e4 into KhronosGroup:SYCL-2020 Nov 4, 2023
7 checks passed
@frasercrmck frasercrmck deleted the rename-rer-to-ref branch November 6, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants