Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Refactor check_lo_hi_odd_even helper #817

Conversation

AlexeySachkov
Copy link
Contributor

Turned it into a more generic function template to avoid explicitly specializing it for every vector size.

Turned it into a more generic function template to avoid explicitly
specializing it for every vector size.
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner October 18, 2023 11:11
@AlexeySachkov
Copy link
Contributor Author

Note for reviewers: I took a version which we had for 16-element vector and generalized it by:

  • using new DO_OPERATION_ON_SWIZZLE macro for swizzle-based operations
  • doing some special-casing for 3-element vectors to skip certain checks (which we should probably do, but this PR is a mere refactoring)

@bader bader added the help wanted Extra attention is needed label Oct 18, 2023
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite shorter!

@bader bader merged commit c06d05b into KhronosGroup:SYCL-2020 Nov 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants