Store scan results by group local ID instead of global ID #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since sub-group IDs are not required to follow the same ordering as the group, the scan test also needs to consider this when computing the results of the sub-group scan. This commit fixes it so the test makes no ordering assumption about neither group nor sub-group, avoiding both faulty expectations and invalid accesses. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
All this code becomes quite convoluted with quite a lot of implicit cognitive burden. Since it might be clear in your brain right now, could you comment the code with the information from the PR plus a lot more :-) so even next week we can understand the code and the context? ;-) |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
@keryell - I added some comments. Are these in line with what you were thinking? |
keryell
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sub-group IDs are not required to follow the same ordering as the group, the scan test also needs to consider this when computing the results of the sub-group scan. This commit fixes it so the test makes no ordering assumption about neither group nor sub-group, avoiding both faulty expectations and invalid accesses.