Replace the SetOperand() with SetInOperand() and SetResultType() #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
266b2ed to
1c848fa
Compare
| @@ -86,8 +86,17 @@ bool DefUseManager::ReplaceAllUsesWith(uint32_t before, uint32_t after) { | |||
|
|
|||
| for (auto it = id_to_uses_[before].cbegin(); it != id_to_uses_[before].cend(); | |||
| ++it) { | |||
| // Make the modification in the instruction. | |||
| it->inst->SetOperand(it->operand_index, {after}); | |||
| uint32_t type_result_id_count = | |||
80c7770 to
6e96663
Compare
|
+2 |
6e96663 to
e8b7c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result id of an instruction should never be changed, as it can be considered as another representation of the instruction.