Add more tests and KillInst() to DefUseManager #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
915b0b1 to
ac73401
Compare
| // false; | ||
| bool ShouldRecord(const ir::Operand& operand) const; | ||
|
|
||
| // Erases the record that: instruction |user| uses id |used_id|. |
|
-1 |
Add KillInst() so that def-use manager can handle instrutions that do not have result ids. Add ClearInst() and ClearDef() private functions. Add tests for AnalyzeInstDefUse(). Add tests for KillInst(). Add a test that call AnalyzeDefUse() on two different modules.
Fix some naming issues. Refactor the ClearInst() and ClearDef() to simplify the code. Remove unnecessary commas in the test cases.
4d7c019 to
db5e0d9
Compare
|
Close as it is moved to #356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add KillInst() so that def-use manager can handle instrutions that do
not have result ids.
Add ClearDef() and ClearInst() two private functions.
Add tests for AnalyzeInstDefUse().
Add tests for KillInst().
Add a test that call AnalyzeDefUse() on two different modules.