Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New IDs for global_variable_fpga_decorations and global_variable_host_access #222

Merged
merged 2 commits into from
Nov 8, 2023
Merged

New IDs for global_variable_fpga_decorations and global_variable_host_access #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
627d1e6
Update
artemrad Oct 27, 2023
bf31942
Nits
artemrad Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions extensions/INTEL/SPV_INTEL_global_variable_fpga_decorations.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ GlobalVariableFPGADecorationsINTEL
[cols="70%,30%"]
[grid="rows"]
|====
|GlobalVariableFPGADecorationsINTEL | 6146
|InitModeINTEL | 6147
|ImplementInRegisterMapINTEL | 6148
|GlobalVariableFPGADecorationsINTEL | 6189
|InitModeINTEL | 6190
|ImplementInRegisterMapINTEL | 6191
|====
--

Expand Down Expand Up @@ -130,7 +130,7 @@ Modify Section 3.20, Decoration, adding these rows to the Decoration table:
2+^.^| Decoration 2+<.^| Extra Operands | Enabling Capabilities

// --- ROW BREAK ---
| 6147
| 6190
a|
*InitModeINTEL* +
Only valid on global (module scope) *OpVariable* which has an _Initializer_
Expand All @@ -149,7 +149,7 @@ _Trigger_
| *GlobalVariableFPGADecorationsINTEL*

// --- ROW BREAK ---
| 6148
| 6191
a|
*ImplementInRegisterMapINTEL* +
Only valid on global (module scope) *OpVariable*.
Expand Down Expand Up @@ -180,7 +180,7 @@ Modify Section 3.31, Capability, adding a row to the Capability table:
[options="header"]
|====
2+^| Capability ^| Implicitly Declares
| 6146
| 6189
| GlobalVariableFPGADecorationsINTEL
|
|====
Expand All @@ -199,4 +199,5 @@ None.
|Rev|Date|Author|Changes
|1|2022-11-1|Gregory Lueck|Initial revision
|2|2023-04-25|Artem Radzikhovskyy| Seperated the FPGA specific decorations from the generic ones
|3|2023-10-27|Artem Radzikhovskyy|Reverting Capability ID
|========================================
130 changes: 68 additions & 62 deletions extensions/INTEL/SPV_INTEL_global_variable_fpga_decorations.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,86 +436,86 @@
@media amzn-kf8{#header,#content,#footnotes,#footer{padding:0}}
</style>
</head>
<body class="article data-line-1">
<body class="article">
<div id="header">
<h1>SPV_INTEL_global_variable_fpga_decorations</h1>
</div>
<div id="content">
<div class="sect1 data-line-12">
<div class="sect1">
<h2 id="_name_strings">Name Strings</h2>
<div class="sectionbody">
<div class="paragraph data-line-14">
<div class="paragraph">
<p>SPV_INTEL_global_variable_fpga_decorations</p>
</div>
</div>
</div>
<div class="sect1 data-line-16">
<div class="sect1">
<h2 id="_contact">Contact</h2>
<div class="sectionbody">
<div class="paragraph data-line-18">
<div class="paragraph">
<p>To report problems with this extension, please open a new issue at:</p>
</div>
<div class="paragraph data-line-20">
<p><a href="https://github.com/KhronosGroup/SPIRV-Registry" class="undefined" data-href="https://github.com/KhronosGroup/SPIRV-Registry">https://github.com/KhronosGroup/SPIRV-Registry</a></p>
<div class="paragraph">
<p><a href="https://github.com/KhronosGroup/SPIRV-Registry" class="bare">https://github.com/KhronosGroup/SPIRV-Registry</a></p>
</div>
</div>
</div>
<div class="sect1 data-line-22">
<div class="sect1">
<h2 id="_contributors">Contributors</h2>
<div class="sectionbody">
<div class="ulist data-line-24">
<div class="ulist">
<ul>
<li class="data-line-24">
<li>
<p>Artem Radzikhovskyy, Intel</p>
</li>
<li class="data-line-25">
<li>
<p>Michael Kinsner, Intel</p>
</li>
<li class="data-line-26">
<li>
<p>Joe Garvey, Intel</p>
</li>
<li class="data-line-27">
<li>
<p>Mohammad Fawaz, Intel</p>
</li>
<li class="data-line-28">
<li>
<p>Gregory Lueck, Intel</p>
</li>
</ul>
</div>
</div>
</div>
<div class="sect1 data-line-30">
<div class="sect1">
<h2 id="_notice">Notice</h2>
<div class="sectionbody">
<div class="paragraph data-line-32">
<div class="paragraph">
<p>Copyright (c) 2021-2023 Intel Corporation. All rights reserved.</p>
</div>
</div>
</div>
<div class="sect1 data-line-34">
<div class="sect1">
<h2 id="_status">Status</h2>
<div class="sectionbody">
<div class="ulist data-line-36">
<div class="ulist">
<ul>
<li class="data-line-36">
<li>
<p>Complete</p>
</li>
</ul>
</div>
</div>
</div>
<div class="sect1 data-line-38">
<div class="sect1">
<h2 id="_version">Version</h2>
<div class="sectionbody">
<table class="tableblock frame-all grid-all data-line-41" style="width: 40%;">
<table class="tableblock frame-all grid-all" style="width: 40%;">
<colgroup>
<col style="width: 50%;">
<col style="width: 50%;">
</colgroup>
<tbody>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">Last Modified Date</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">2023-06-14</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">2023-11-02</p></td>
</tr>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">Revision</p></td>
Expand All @@ -525,101 +525,101 @@ <h2 id="_version">Version</h2>
</table>
</div>
</div>
<div class="sect1 data-line-46">
<div class="sect1">
<h2 id="_dependencies">Dependencies</h2>
<div class="sectionbody">
<div class="paragraph data-line-48">
<div class="paragraph">
<p>This extension is written against the SPIR-V Specification,
Version 1.6 Revision 2.</p>
</div>
<div class="paragraph data-line-51">
<div class="paragraph">
<p>This extension requires SPIR-V 1.0.</p>
</div>
</div>
</div>
<div class="sect1 data-line-53">
<div class="sect1">
<h2 id="_overview">Overview</h2>
<div class="sectionbody">
<div class="paragraph data-line-55">
<div class="paragraph">
<p>This extension adds decorations that can be applied to global (module scope)
variables. These decorations are intended to help code generation for
FPGA devices, they can be ignored by all other consumers of this extension.</p>
</div>
</div>
</div>
<div class="sect1 data-line-59">
<div class="sect1">
<h2 id="_extension_name">Extension Name</h2>
<div class="sectionbody">
<div class="paragraph data-line-60">
<div class="paragraph">
<p>To use this extension within a SPIR-V module, the following <strong>OpExtension</strong> must
be present in the module:</p>
</div>
<div class="listingblock data-line-63">
<div class="listingblock">
<div class="content">
<pre>OpExtension "SPV_INTEL_global_variable_fpga_decorations"</pre>
</div>
</div>
</div>
</div>
<div class="sect1 data-line-67">
<div class="sect1">
<h2 id="_new_capabilities">New Capabilities</h2>
<div class="sectionbody">
<div class="paragraph data-line-68">
<div class="paragraph">
<p>This extension introduces a new capability:</p>
</div>
<div class="listingblock data-line-70">
<div class="listingblock">
<div class="content">
<pre>GlobalVariableFPGADecorationsINTEL</pre>
</div>
</div>
</div>
</div>
<div class="sect1 data-line-74">
<div class="sect1">
<h2 id="_token_number_assignments">Token Number Assignments</h2>
<div class="sectionbody">
<div class="openblock data-line-76">
<div class="openblock">
<div class="content">
<table class="tableblock frame-all grid-rows data-line-80" style="width: 40%;">
<table class="tableblock frame-all grid-rows" style="width: 40%;">
<colgroup>
<col style="width: 70%;">
<col style="width: 30%;">
</colgroup>
<tbody>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">GlobalVariableFPGADecorationsINTEL</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">6146</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">6189</p></td>
</tr>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">InitModeINTEL</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">6147</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">6190</p></td>
</tr>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">ImplementInRegisterMapINTEL</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">6148</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">6191</p></td>
</tr>
</tbody>
</table>
</div>
</div>
</div>
</div>
<div class="sect1 data-line-87">
<div class="sect1">
<h2 id="_modifications_to_the_spir_v_specification_version_1_6">Modifications to the SPIR-V Specification, Version 1.6</h2>
<div class="sectionbody">
<div class="sect2 data-line-89">
<div class="sect2">
<h3 id="_initialization_mode_qualifier">Initialization Mode Qualifier</h3>
<div class="paragraph data-line-91">
<div class="paragraph">
<p>After Section 3.18, add a new section "3.18a Initialization Mode Qualifier" as follows</p>
</div>
<div class="paragraph data-line-93">
<div class="paragraph">
<p>Defines how the initialization should be triggered.</p>
</div>
<div class="paragraph data-line-95">
<div class="paragraph">
<p>Used by InitModeINTEL.</p>
</div>
<div class="openblock data-line-97">
<div class="openblock">
<div class="content">
<table class="tableblock frame-all grid-all stretch data-line-99">
<table class="tableblock frame-all grid-all stretch">
<colgroup>
<col style="width: 33.3333%;">
<col style="width: 33.3333%;">
Expand Down Expand Up @@ -653,14 +653,14 @@ <h3 id="_initialization_mode_qualifier">Initialization Mode Qualifier</h3>
</div>
</div>
</div>
<div class="sect2 data-line-123">
<div class="sect2">
<h3 id="_decoration">Decoration</h3>
<div class="paragraph data-line-125">
<div class="paragraph">
<p>Modify Section 3.20, Decoration, adding these rows to the Decoration table:</p>
</div>
<div class="openblock data-line-127">
<div class="openblock">
<div class="content">
<table class="tableblock frame-all grid-all stretch data-line-129">
<table class="tableblock frame-all grid-all stretch">
<colgroup>
<col style="width: 7.1428%;">
<col style="width: 35.7142%;">
Expand All @@ -677,7 +677,7 @@ <h3 id="_decoration">Decoration</h3>
</thead>
<tbody>
<tr>
<td class="tableblock halign-center valign-top"><p class="tableblock">6147</p></td>
<td class="tableblock halign-center valign-top"><p class="tableblock">6190</p></td>
<td class="tableblock halign-left valign-top"><div class="content"><div class="paragraph">
<p><strong>InitModeINTEL</strong><br>
Only valid on global (module scope) <strong>OpVariable</strong> which has an <em>Initializer</em>
Expand All @@ -698,7 +698,7 @@ <h3 id="_decoration">Decoration</h3>
<td class="tableblock halign-left valign-top"><p class="tableblock"><strong>GlobalVariableFPGADecorationsINTEL</strong></p></td>
</tr>
<tr>
<td class="tableblock halign-center valign-top"><p class="tableblock">6148</p></td>
<td class="tableblock halign-center valign-top"><p class="tableblock">6191</p></td>
<td class="tableblock halign-left valign-top"><div class="content"><div class="paragraph">
<p><strong>ImplementInRegisterMapINTEL</strong><br>
Only valid on global (module scope) <strong>OpVariable</strong>.</p>
Expand Down Expand Up @@ -734,14 +734,14 @@ <h3 id="_decoration">Decoration</h3>
</div>
</div>
</div>
<div class="sect2 data-line-176">
<div class="sect2">
<h3 id="_capability">Capability</h3>
<div class="paragraph data-line-178">
<div class="paragraph">
<p>Modify Section 3.31, Capability, adding a row to the Capability table:</p>
</div>
<div class="openblock data-line-179">
<div class="openblock">
<div class="content">
<table class="tableblock frame-all grid-all stretch data-line-181">
<table class="tableblock frame-all grid-all stretch">
<colgroup>
<col style="width: 33.3333%;">
<col style="width: 33.3333%;">
Expand All @@ -755,7 +755,7 @@ <h3 id="_capability">Capability</h3>
</thead>
<tbody>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">6146</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">6189</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">GlobalVariableFPGADecorationsINTEL</p></td>
<td class="tableblock halign-left valign-top"></td>
</tr>
Expand All @@ -766,18 +766,18 @@ <h3 id="_capability">Capability</h3>
</div>
</div>
</div>
<div class="sect1 data-line-189">
<div class="sect1">
<h2 id="_issues">Issues</h2>
<div class="sectionbody">
<div class="paragraph data-line-191">
<div class="paragraph">
<p>None.</p>
</div>
</div>
</div>
<div class="sect1 data-line-193">
<div class="sect1">
<h2 id="_revision_history">Revision History</h2>
<div class="sectionbody">
<table class="tableblock frame-all grid-rows stretch data-line-198">
<table class="tableblock frame-all grid-rows stretch">
<colgroup>
<col style="width: 4.7619%;">
<col style="width: 14.2857%;">
Expand Down Expand Up @@ -805,14 +805,20 @@ <h2 id="_revision_history">Revision History</h2>
<td class="tableblock halign-left valign-top"><p class="tableblock">Artem Radzikhovskyy</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">Seperated the FPGA specific decorations from the generic ones</p></td>
</tr>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">3</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">2023-10-27</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">Artem Radzikhovskyy</p></td>
<td class="tableblock halign-left valign-top"><p class="tableblock">Reverting Capability ID</p></td>
</tr>
</tbody>
</table>
</div>
</div>
</div>
<div id="footer">
<div id="footer-text">
Last updated 2023-06-14 06:29:18 -0700
Last updated 2023-11-02 10:46:00 -0700
</div>
</div>
</body>
Expand Down
Loading