Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change token IDs for global_variable_fpga_decorations and global_variable_host_access #389

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Change token IDs for global_variable_fpga_decorations and global_variable_host_access #389

merged 1 commit into from
Nov 15, 2023

Conversation

vmaksimo
Copy link
Contributor

Relates to the recent change in SPIRV-Registry: KhronosGroup/SPIRV-Registry#222

@vmaksimo
Change token IDs for global_variable_fpga_decorations and global_vari…
63c00e1 
…able_host_access

Relates to the recent change in SPIRV-Registry:  KhronosGroup/SPIRV-Registry#222
@vmaksimo vmaksimo requested a review from bashbaug November 13, 2023 11:59
bashbaug
bashbaug approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches the enum assignment in the latest specs.

It would be nice to have a non-Intel reviewer before merging.

@bashbaug
Copy link
Contributor

Merging as discussed in the November 15th teleconference.

@bashbaug bashbaug merged commit cca08c6 into KhronosGroup:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmaksimo @bashbaug