-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🔥AUDIT🔥] [rg.audit.3] Fix keys typing #620
Conversation
🦋 Changeset detectedLatest commit: f339a3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 4.42 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 87
Lines 1322 1319 -3
Branches 331 316 -15
=========================================
- Hits 1322 1319 -3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. 💚
🖍 This is an audit! 🖍
Summary:
This updates the typing of the
keys
function to match better with our expected usage.Issue: FEI-4960
Test plan:
yarn typecheck
Also built the types and tried them in webapp to verify they now work as we would want.