Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] [rg.audit.3] Fix keys typing #620

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Conversation

somewhatabstract
Copy link
Member

🖍 This is an audit! 🖍

Summary:

This updates the typing of the keys function to match better with our expected usage.

Issue: FEI-4960

Test plan:

yarn typecheck

Also built the types and tried them in webapp to verify they now work as we would want.

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: f339a3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@khanacademy/wonder-stuff-core Patch
@khanacademy/wonder-stuff-render-environment-jsdom Patch
@khanacademy/wonder-stuff-render-server Patch
@khanacademy/wonder-stuff-sentry Patch
@khanacademy/wonder-stuff-server Patch
@khanacademy/wonder-stuff-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@somewhatabstract somewhatabstract self-assigned this Apr 3, 2023
@somewhatabstract somewhatabstract requested a review from a team April 3, 2023 20:41
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/stupid-beds-walk.md, packages/wonder-stuff-core/src/keys.ts, packages/wonder-stuff-core/src/__tests__/keys.typestest.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team April 3, 2023 20:41
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Size Change: 0 B

Total Size: 4.42 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.78 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.66 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 970 B

compressed-size-action

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #620 (f339a3d) into main (d0c21c7) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #620   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines         1322      1319    -3     
  Branches       331       316   -15     
=========================================
- Hits          1322      1319    -3     
Impacted Files Coverage Δ
packages/wonder-stuff-core/src/keys.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c21c7...f339a3d. Read the comment docs.

@somewhatabstract somewhatabstract merged commit b28725a into main Apr 3, 2023
@somewhatabstract somewhatabstract deleted the rg.audit.3 branch April 3, 2023 20:51
Copy link
Contributor

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants