WB-1645.pre: Append className value in Text component (fix) #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c3df0ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: +23 B (0%) Total Size: 91.2 kB
ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2138 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 242 242
Lines 28053 28058 +5
Branches 2456 2409 -47
=======================================
+ Hits 27227 27232 +5
Misses 826 826
Continue to review full report in Codecov by Sentry.
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (cb24a4c) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2138"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2138 |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-dnmcmrmdjj.chromatic.com/ Chromatic results:
|
jeresig
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on adding custom option items to Dropdowns, I noticed that the
classNameprop was not being appended to theTextcomponent. This PR fixesthat by changing the logic to append the
classNameprop to theTextif itincludes both a
classNameand astyleprop.Also updated the typography docs to include an example of using the
styleandclassNameprops.Issue: WB-1645
Test plan:
Verify that the unit tests pass.
Also verify that the following story works as expected:
http://localhost:6061/?path=/docs/typography--docs#with-style
style).className+css()).className+ and external css import).