Move scorers: Plotter and Sorter

[handeyeco]

Summary:

I moved these together because they both depended on Utils.deepEq which I moved to _.isEqual (which is deep equality).

Issue: LEMS-2737

Test plan:

Nothing should change

[github-actions]

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (806808a) and published it to npm. You
can install it using the tag PR2113.

Example:

yarn add @khanacademy/perseus@PR2113

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2113

[github-actions]

Size Change: +139 B (+0.01%)

Total Size: 1.47 MB

Filename	Size	Change
packages/kmath/dist/es/index.js	86.8 kB	+3.71 kB (+4.47%)
packages/math-input/dist/es/index.js	77.6 kB	-355 B (-0.46%)
packages/perseus-core/dist/es/index.js	27.1 kB	+4.03 kB (+17.47%)	⚠️
packages/perseus-editor/dist/es/index.js	689 kB	-152 B (-0.02%)
packages/perseus-score/dist/es/index.js	113 kB	+4.86 kB (+4.51%)	🔍
packages/perseus/dist/es/index.js	394 kB	-12 kB (-2.95%)
packages/perseus/dist/es/strings.js	4.87 kB	+18 B (+0.37%)

ℹ️ View Unchanged

Filename	Size
packages/kas/dist/es/index.js	39 kB
packages/keypad-context/dist/es/index.js	760 B
packages/math-input/dist/es/strings.js	1.79 kB
packages/perseus-linter/dist/es/index.js	22.2 kB
packages/pure-markdown/dist/es/index.js	3.66 kB
packages/simple-markdown/dist/es/index.js	12.5 kB

_{compressed-size-action}

[benchristel]

LGTM! Left one question inline about underscore.

[benchristel]

I vaguely remember we were talking about trying to get rid of underscore at some point. Was that only for functions like _.map that have native equivalents now?

[jeremywiebe]

Where native equivalents exist, I think we should switch away from underscore. For cases like this, it'd be nice if we had a single deep equality check. I think we actually want to revert this change because our "in-house" deepEq uses an approximate equals check for numeric values.

Suggested change

	earned: _.isEqual(userInput, scoringData.correct) ? 1 : 0,
	earned: deepEq(userInput, scoringData.correct) ? 1 : 0,

[handeyeco]

Yeah, that's right. I need to go back and undo the change to underscore. I think what I'll do is add another PR to the top because I also renamed eq and deepEq (in a later PR) to make it clearer that they're approximate.

[handeyeco]

#2125

[handeyeco]

Just to add another thought.

Was that only for functions like _.map that have native equivalents now?

I think we should absolutely not use jQuery/Underscore for things that have native equivalents (map, each, etc).

I also don't think we should be reinventing complex logic that's not native and provided through something like Underscore.

In this case it wasn't clear to me that these were approximate equality checks, so I didn't see the need to reinvent the wheel when we depend on Underscore and Underscore has isEqual. Now that I know that these are fairly specific helpers, I know now we should have kept them. I renamed them to approximateDeepEqual and approximateEqual to prevent people from making my mistake in the future.