-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Linear - Add the interactive elements linear description to the whole graph container #2110
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
30333ff
[SR] Linear graph - add grab handle description and aria lives
nishasy 586c962
docs(changeset): [SR] Linear graph - add grab handle description and …
nishasy ee8b9b2
Merge branch 'main' into sr-linear-body
nishasy a5ef0f8
Linear System SR
nishasy 0fbbbfa
docs(changeset): [SR] Linear System - add screen reader support for L…
nishasy 48f17c5
Ray SR
nishasy 625c9a4
docs(changeset): [SR] Ray graph - Add screen reader support for Ray i…
nishasy 951fc96
Merge branch 'main' into sr-linear-system
nishasy 193ee2a
fix misunderstanding from linear PR. update tests
nishasy 1ffe7fa
Merge branch 'sr-linear-system' into sr-ray
nishasy f754610
update test
nishasy c01b4f6
Merge branch 'main' into sr-linear-system
nishasy b315fbf
remove contexts from strings
nishasy 7d96885
Add full graph description of all interactive elements
nishasy 8c8cbf5
Merge branch 'sr-linear-system' into sr-ray
nishasy 33e209a
remove context from strings
nishasy 914ea5a
Add full graph description of interactive element
nishasy 9ac9782
Rename lineSequence --> lineNumber
nishasy c242323
Merge branch 'sr-linear-system' into sr-ray
nishasy 5b48e40
Create custom matcher for aria descriptions
nishasy 24f71a1
Include ID in template string
nishasy 8669b75
Use srOnly style instead of invalid display hidden
nishasy ed8ccbd
use isFinite
nishasy 4523ca0
Merge branch 'main' into sr-linear-system
nishasy 07b60bf
Merge branch 'sr-linear-system' into sr-ray
nishasy e625ea6
use srOnly style
nishasy c56b3c3
use new matcher for aria descriptions in test
nishasy f8c8c11
handle SR for lines overlapping axes
nishasy 1dcf3fd
Use existing aria description matcher rather than creating a new one
nishasy d64ac0d
correct string in test
nishasy a2210a5
Merge branch 'sr-linear-system' into sr-ray
nishasy 1728c68
[SR] Linear - Add the interactive elements linear description to the …
nishasy efb68a8
docs(changeset): [SR] Linear - Add the interactive elements linear de…
nishasy 91f3166
Fix comments
nishasy 98ac47c
Merge branch 'sr-ray' into sr-linear-interactive-elements
nishasy 4468c3e
Add types
nishasy cbd82f6
Merge branch 'sr-linear-system' into sr-ray
nishasy 1bd1d6e
Merge branch 'sr-ray' into sr-linear-interactive-elements
nishasy 2a45174
fix import
nishasy e4a7322
fix import
nishasy 11f2a4a
Update grab handle description to match SRUX doc
nishasy 336ac2f
Merge branch 'sr-linear-system' into sr-ray
nishasy a164397
Update copy to match SRUX doc
nishasy 5bd5903
Merge branch 'sr-ray' into sr-linear-interactive-elements
nishasy 8e9201d
Merge branch 'main' into sr-linear-interactive-elements
nishasy f20fb25
Merge branch 'main' into sr-linear-interactive-elements
nishasy 05e1c6b
[sr-linear-interactive-elements] Merge branch 'main' into sr-linear-i…
nishasy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus": patch | ||
--- | ||
|
||
[SR] Linear - Add the interactive elements linear description to the whole graph container |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pass in the
i18n
content into this function? Typically if you have a function that relies on the content or result of a hook you can avoid turning it into a component by simply passing the content through a parameter.