Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LEMS-2484): add description for sinusoid #2094

Open
wants to merge 35 commits into
base: LEMS-2484-minimally-describe-sinusoid
Choose a base branch
from

Conversation

anakaren-rojas
Copy link
Contributor

@anakaren-rojas anakaren-rojas commented Jan 10, 2025

Summary:

Aria description for the sinusoid graph. Includes

  • Calculation of min and max values of the graph
  • Calculation of the length of a full wave
  • Conversion of x coordinates to pi intervals
  • Calculation of the coordinates that encapsulate 1 full wave

Issue: LEMS-2484

Test plan:

ZND
https://prod-znd-250116-anakaren-3.khanacademy.org/internal-courses/test-everything/test-everything-1/te-interactive-graph/e/sinusoid-graph-exercise

Screenshot:

Screenshot 2025-01-16 at 16 19 03

@anakaren-rojas anakaren-rojas self-assigned this Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (41430e8) and published it to npm. You
can install it using the tag PR2094.

Example:

yarn add @khanacademy/perseus@PR2094

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2094

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Size Change: +994 B (+0.07%)

Total Size: 1.47 MB

Filename Size Change
packages/perseus/dist/es/index.js 396 kB +846 B (+0.21%)
packages/perseus/dist/es/strings.js 5.32 kB +148 B (+2.86%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 86.8 kB
packages/math-input/dist/es/index.js 77.6 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 27.1 kB
packages/perseus-editor/dist/es/index.js 689 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus-score/dist/es/index.js 113 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@anakaren-rojas anakaren-rojas changed the title add description for sinusoid feat(LEMS-2484): add description for sinusoid Jan 10, 2025
@anakaren-rojas anakaren-rojas marked this pull request as ready for review January 13, 2025 23:08
@anakaren-rojas anakaren-rojas changed the base branch from LEMS-2484-minimally-describe-sinusoid to main January 13, 2025 23:31
@anakaren-rojas anakaren-rojas changed the base branch from main to LEMS-2484-minimally-describe-sinusoid January 17, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants