Allow keyboard navigation of images #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4ecee88) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1990If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1990 |
|
Size Change: +48 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
mark-fitzgerald
approved these changes
Dec 12, 2024
20b2272 to
346e7ed
Compare
Merged
SonicScrewdriver
added a commit
that referenced
this pull request
Jan 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/math-input@22.1.0 ### Minor Changes - [#1738](#1738) [`dbbc82f2d`](dbbc82f) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - add scientific notation button / toggle to basic keypad ## @khanacademy/perseus@49.2.0 ### Minor Changes - [#1990](#1990) [`37c642f24`](37c642f) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Allow keyboards to navigate and interact with images - [#1738](#1738) [`dbbc82f2d`](dbbc82f) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - add scientific notation button / toggle to basic keypad ### Patch Changes - [#2061](#2061) [`d8b2f7eaf`](d8b2f7e) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - update terminology for angle sides - [#2071](#2071) [`bac10129b`](bac1012) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - This patch fixes our Perseus strings to ensure that they are double escaped for Lingui. - [#1952](#1952) [`617377147`](6173771) Thanks [@benchristel](https://github.com/benchristel)! - Internal: add and pass more regression tests for PerseusItem parser - [#2059](#2059) [`53ba9f5d1`](53ba9f5) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Dropdown] Bugfix - Text in dropdown was shifted up after adding TeX support via Renderer - Updated dependencies \[[`dbbc82f2d`](dbbc82f)]: - @khanacademy/math-input@22.1.0 ## @khanacademy/perseus-editor@17.1.0 ### Minor Changes - [#1738](#1738) [`dbbc82f2d`](dbbc82f) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - add scientific notation button / toggle to basic keypad ### Patch Changes - Updated dependencies \[[`d8b2f7eaf`](d8b2f7e), [`bac10129b`](bac1012), [`37c642f24`](37c642f), [`617377147`](6173771), [`dbbc82f2d`](dbbc82f), [`53ba9f5d1`](53ba9f5)]: - @khanacademy/perseus@49.2.0 - @khanacademy/math-input@22.1.0 ## @khanacademy/perseus-dev-ui@5.0.10 ### Patch Changes - Updated dependencies \[[`dbbc82f2d`](dbbc82f)]: - @khanacademy/math-input@22.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR allows the keyboard navigation of our images so that users can easily interact with the zoom functionality. I have also added the spacebar and enter keys as optional methods for closing the image, just to help avoid any confusion for our users.
Issue: LEMS-2697
Test plan: