Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Numeric Input] - Update editor screen to be more organized #1951

Closed
wants to merge 15 commits into from
+248 −211
Closed

[Numeric Input] - Update editor screen to be more organized #1951

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7396d11
Add headings for "Common Settings" and "Answers" sections.
Dec 4, 2024
b88706d
Individual answers moved to their own accordion.
Dec 5, 2024
c8ac23e
Move delete button to bottom of individual answer panel.
Dec 5, 2024
4af63e0
Move settings labels to individual answer sections.
Dec 5, 2024
d25188a
Update unit tests to account for Unique IDs in WB Accordion.
Dec 5, 2024
3a03430
Changeset
Dec 5, 2024
c7d6c6c
Merge branch 'main' into LEMS-2455-update-layout-editor-for-numeric-i…
Dec 5, 2024
b7abe6e
Remove TS comment (no good way to resolve).
Dec 5, 2024
17bad82
Adjust for Typescript issue.
Dec 5, 2024
c507630
Merge branch 'main' into LEMS-2455-update-layout-editor-for-numeric-i…
Dec 5, 2024
e363ae7
Remove toggle button for additional answer options, and always show t…
Dec 6, 2024
1724cf4
Remove unused objects from code.
Dec 6, 2024
8d605d2
Prettier
Dec 6, 2024
9531c07
Merge branch 'main' into LEMS-2455-update-layout-editor-for-numeric-i…
Dec 9, 2024
accfafb
Correct assignment of new state when toggling heading accordion.
Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Remove TS comment (no good way to resolve).
Mark Fitzgerald committed Dec 5, 2024
commit b7abe6e46a404fbeebe5498543cb6137d9612efe
1 change: 0 additions & 1 deletion packages/perseus-editor/src/widgets/numeric-input-editor.tsx
View file
Original file line number Diff line number Diff line change
@@ -157,8 +157,7 @@
return () => {
const toggleName = `show${accordionName}`;
const newState = {[toggleName]: !this.state[toggleName]};
// @ts-expect-error
this.setState(newState);

Check failure on line 160 in packages/perseus-editor/src/widgets/numeric-input-editor.tsx

GitHub Actions / Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x) 

Argument of type '{ [x: string]: boolean; }' is not assignable to parameter of type 'State | ((prevState: Readonly<State>, props: Readonly<Props>) => State | Pick<State, keyof State> | null) | Pick<...> | null'.

Check failure on line 160 in packages/perseus-editor/src/widgets/numeric-input-editor.tsx

GitHub Actions / Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x) 

Argument of type '{ [x: string]: boolean; }' is not assignable to parameter of type 'State | ((prevState: Readonly<State>, props: Readonly<Props>) => State | Pick<State, keyof State> | null) | Pick<...> | null'.
};
};