Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Interactive Graph Cypress tests #1430

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jul 22, 2024

Summary:

See this thread

We're moving to Mafs / RTL and these are tests for the old Interactive Graph. Plus it's breaking my PR.

@handeyeco handeyeco self-assigned this Jul 22, 2024
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (1d6e344) and published it to npm. You
can install it using the tag PR1430.

Example:

yarn add @khanacademy/perseus@PR1430

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1430

@handeyeco handeyeco requested review from jeremywiebe, benchristel and a team July 22, 2024 17:23
Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Size Change: 0 B

Total Size: 854 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 80.8 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 273 kB
packages/perseus-linter/dist/es/index.js 21.6 kB
packages/perseus/dist/es/index.js 414 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@handeyeco handeyeco merged commit 1e4e7f3 into main Jul 22, 2024
15 of 18 checks passed
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (daa3082) to head (1d6e344).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
+ Coverage   69.80%   70.42%   +0.61%     
==========================================
  Files         505      508       +3     
  Lines      105660   105698      +38     
  Branches     7647    10815    +3168     
==========================================
+ Hits        73761    74442     +681     
+ Misses      31720    31256     -464     
+ Partials      179        0     -179     

Impacted file tree graph

see 147 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa3082...1d6e344. Read the comment docs.

@handeyeco handeyeco deleted the remove-graph-cypress branch July 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants