-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize locked figures into own folder #1368
Organize locked figures into own folder #1368
Conversation
Update references in consuming files.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (525ea1d) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1368 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1368 |
Size Change: -240 B (-0.03%) Total Size: 846 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
==========================================
+ Coverage 69.83% 70.90% +1.07%
==========================================
Files 491 495 +4
Lines 103846 103924 +78
Branches 7491 11193 +3702
==========================================
+ Hits 72516 73688 +1172
+ Misses 31152 30236 -916
+ Partials 178 0 -178
... and 138 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
The number of files dedicated to locked figures has reached a point where we should group them for better organization.