Address PR feedback

Move validation check to top of scoring function Make test function an arrow function
Khan · Dec 17, 2024 · a6fdf94 · a6fdf94
1 parent 25288ad
commit a6fdf94
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/perseus/src/widgets/label-image/score-label-image.ts b/packages/perseus/src/widgets/label-image/score-label-image.ts
@@ -46,6 +46,11 @@ function scoreLabelImage(
     userInput: PerseusLabelImageUserInput,
     scoringData: PerseusLabelImageScoringData,
 ): PerseusScore {
+    const validationError = validateLabelImage(userInput);
+    if (validationError) {
+        return validationError;
+    }
+
     let numCorrect = 0;
 
     for (let i = 0; i < userInput.markers.length; i++) {
@@ -59,11 +64,6 @@ function scoreLabelImage(
         }
     }
 
-    const validationError = validateLabelImage(userInput);
-    if (validationError) {
-        return validationError;
-    }
-
     return {
         type: "points",
         // Markers with no expected answers are graded as correct if user

diff --git a/packages/perseus/src/widgets/label-image/validate-label-image.test.ts b/packages/perseus/src/widgets/label-image/validate-label-image.test.ts
@@ -2,7 +2,7 @@ import validateLabelImage from "./validate-label-image";
 
 import type {PerseusLabelImageUserInput} from "../../validation.types";
 
-describe("scoreLabelImage", function () {
+describe("scoreLabelImage", () => {
     it("should not grade non-interacted widget", function () {
         const userInput: PerseusLabelImageUserInput = {
             markers: [{label: "England"}, {label: "Germany"}, {label: "Italy"}],