-
Notifications
You must be signed in to change notification settings - Fork 350
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update function signature for getUserInputFromProps (#1842)
## Summary: In my prior PR [where I updated this function signature](614425b), I wasn't aware that it was called outside of the component anywhere. It turns out in Web App, [there are calls to getUserInputFromProps](https://github.com/Khan/webapp/blob/master/services/static/javascript/coach-report-package/responses/utils.ts#L75) and this change to the function signature breaks those calls. ## Test plan: - Ensure the tests pass
- Loading branch information
Showing
3 changed files
with
163 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus": patch | ||
--- | ||
|
||
Fix function signature of getUserInputFromProps for radio widget |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters