Update our vendored deps to more modern versions. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I match the one from webapp. The important thing is that it's recent enough to work with the version of Go we run now. Issue: none Test plan: I successfully ran `ka-lint formatter.go` in the Khan/stackdriver-gae-logrus-plugin directory.
Issue: https://khanacademy.slack.com/archives/C02NV1DPJ/p1726506371960829 Test plan: I ran this successfully: ``` python3.12 -c 'import flake8.api.legacy; flake8.api.legacy.get_style_guide() ``` Before this change, it gave an import error.
ac89820 to
1cd4b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The vendored
golangci-lintdidn't work with the version of Gowe're using now. The vendored
pyflakesdidn't work withpython3.12. (Which is not the version we're using now, but
some people have it installed as their default.)
I should probably update the javascript deps as well,
but they don't seem to be broken for anything so I'm
leaving them alone for now. I don't know how to test
the upgrades very well.
I now match the versions we use in webapp.
Issue: https://khanacademy.slack.com/archives/C02NV1DPJ/p1726506371960829
Test plan:
For Go, I successfully ran
ka-lint formatter.goin theKhan/stackdriver-gae-logrus-plugin directory.
For Python, I successfully ran
Before this change, it gave an import error.