Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding bitrise ymls to blocklist of linter #39

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

jlauzy
Copy link
Member

@jlauzy jlauzy commented Jul 6, 2022

Summary:

Due to "narrow" build python not being able to support the unicode for some emojis used in our build process,I am adding the bitrise yml files to the linting blocklist until we do the python3 upgrade.

Issue: XXX-XXXX

Test plan:

N/A, can write a unit test that shows the linter will skip the files?

@jlauzy jlauzy self-assigned this Jul 6, 2022
@jlauzy jlauzy requested a review from csilvers July 6, 2022 22:50
Copy link
Member

@csilvers csilvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Sorry for the delay in reviewing, I've been on vacation.

@jlauzy jlauzy merged commit 9222e8f into master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants