Filter out deleted paths from files_to_lint in the pre-push hook #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm a little wary about changing this as I have never personally used it (I deleted all git hooks shortly after cloning webapp the first time), but this feels like a minimally invasive change. Issue: https://khanacademy.atlassian.net/browse/FEI-3574 Test plan: 🤞
kevinbarabash
approved these changes
Aug 3, 2021
somewhatabstract
approved these changes
Aug 4, 2021
Comment on lines
+178
to
+179
| files_to_lint = list({f for f in files_to_lint.split('\0') | ||
| if f and os.path.exists(f)}) |
There was a problem hiding this comment.
Oh, that's a neat way of handling it. Nice. I was envisioning needing to change the command that gets the list of files in the first place. Nice. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm a little wary about changing this as I have never personally used it (I deleted all git hooks shortly after cloning webapp the first time),
but this feels like a minimally invasive change.
Issue: https://khanacademy.atlassian.net/browse/FEI-3574
Test plan:
🤞