Skip to content

Commit

Permalink
One more place we have to fix things up for python3. (#46)
Browse files Browse the repository at this point in the history
## Summary:
Nobody noticed because nobody is using the default ka-linter, I guess.
Except me.

Issue: none

## Test plan:
I ran `ka-lint formatter.go` in the Khan/stackdriver-gae-logrus-plugin
directory, and no longer got an error running subprocess.

Author: csilvers

Reviewers: MiguelCastillo

Required Reviewers:

Approved By: MiguelCastillo

Checks:

Pull Request URL: #46
  • Loading branch information
csilvers authored Oct 7, 2024
1 parent aead10d commit 024a286
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion linters.py
Original file line number Diff line number Diff line change
Expand Up @@ -1241,7 +1241,8 @@ def process_files(self, files):
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)

stdout, stderr = process.communicate(input='\0'.join(dirs))
stdout, stderr = process.communicate(
input='\0'.join(dirs).encode('utf-8'))
stdout, stderr = stdout.decode('utf-8'), stderr.decode('utf-8')

# golangci-lint seems to exit 123 on errors, even if you tell it not to
Expand Down

0 comments on commit 024a286

Please sign in to comment.