Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking some nits that my IDE complained about #91

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Conversation

StevenACoffman
Copy link
Member

Signed-off-by: Steve Coffman steve@khanacademy.org

Copy link
Collaborator

@benjaminjkraft benjaminjkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok -- a couple of these I don't like and I'm not sure what the IDE is complaining about, but the rest seem fine.

StevenACoffman and others added 3 commits September 14, 2021 13:37
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Co-authored-by: Ben Kraft <benkraft@khanacademy.org>
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman merged commit 673840e into main Sep 14, 2021
@StevenACoffman StevenACoffman deleted the picking_nits branch September 14, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants