Skip to content

Commit

Permalink
[πŸ”₯AUDITπŸ”₯] Mark interfaces as enabled! (#67)
Browse files Browse the repository at this point in the history
πŸ– _This is an audit!_ πŸ–

## Summary:
We've completed support for interfaces!  Fragments are still pending,
but interfaces by themselves should be usable.  But I forgot to actually
remove the flag they were behind.  In this commit I do!

Issue: https://khanacademy.slack.com/archives/C01120CNCS0/p1630012808004100

## Test plan:
make check


Author: benjaminjkraft

Auditors: aberkan, csilvers, dnerdy, MiguelCastillo

Required Reviewers: 

Approved by: 

Checks: βŒ› Test (1.17), βŒ› Test (1.16), βŒ› Test (1.15), βŒ› Test (1.14), βŒ› Test (1.13), βŒ› Lint, βŒ› Test (1.17), βŒ› Test (1.16), βŒ› Test (1.15), βŒ› Test (1.14), βŒ› Test (1.13), βœ… Lint

Pull request URL: #67
  • Loading branch information
benjaminjkraft authored Aug 26, 2021
1 parent 8f9d1cf commit bf266d8
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions generate/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -256,10 +256,6 @@ func (g *generator) convertDefinition(
return goType, nil

case ast.Interface, ast.Union:
if !g.Config.AllowBrokenFeatures {
return nil, errorf(pos, "not implemented: %v", def.Kind)
}

implementationTypes := g.schema.GetPossibleTypes(def)
goType := &goInterfaceType{
GoName: name,
Expand Down

0 comments on commit bf266d8

Please sign in to comment.